Skip to content

Combine the test discovery implementations for WASI and static Mach-O. #761

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2024
Merged

Combine the test discovery implementations for WASI and static Mach-O. #761

merged 2 commits into from
Oct 10, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 10, 2024 •
edited
Loading

This PR reduces code duplication between the two supported platforms that do not use dynamic linking during test discovery.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Combine the test discovery implementations for WASI and static Mach-O.
9d58a1b 
This PR reduces code duplication between the two supported platforms that do not
use dynamic linking during test discovery.
@grynspan grynspan added darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support wasi/wasm 🧭 WebAssembly support labels Oct 10, 2024
@grynspan grynspan self-assigned this Oct 10, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit c811d17 into main Oct 10, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/combine-static-discovery-impls branch October 10, 2024 19:44
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support discovery 🔎 test content discovery wasi/wasm 🧭 WebAssembly support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @briancroom