Skip to content

Fix missing newlines in error JSON propagated from an exit test. #767

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix missing newlines in error JSON propagated from an exit test. #767

merged 2 commits into from
Oct 16, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 16, 2024 •
edited
Loading

We weren't emitting newlines between exit test backchannel JSON blobs. Oops.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix missing newlines in error JSON propagated from an exit test.
d138eae 
We weren't emitting newlines between exit test backchannel JSON blobs. Oops.
@grynspan grynspan added bug 🪲 Something isn't working exit-tests ☠️ Work related to exit tests labels Oct 16, 2024
@grynspan grynspan added this to the Swift 6.1 milestone Oct 16, 2024
@grynspan grynspan self-assigned this Oct 16, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Oct 16, 2024
@grynspan
Copy link
Contributor Author

Will self-review as it's a tiny change in code nobody else knows well yet.

@grynspan grynspan merged commit 751ea94 into main Oct 16, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/missing-newlines-in-exit-test-errors branch October 16, 2024 04:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stmontgomery stmontgomery

@dennisweissmann dennisweissmann

@briancroom briancroom

@SeanROlszewski SeanROlszewski

@suzannaratcliff suzannaratcliff

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working exit-tests ☠️ Work related to exit tests self-reviewed PR was self-reviewed by a code owner
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
1 participant
@grynspan