Update documentation to explain misconfigurations of SWT_ conditions.
#772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was supposed to be part of #769, but I must have blown away a local commit because it didn't make it into that PR. This PR updates Porting.md to explain when a developer might encounter an error due to mismatched `SWT_` conditions. It ensures that exit tests require process spawning to be enabled/implemented by adding a dependency between `SWT_NO_PROCESS_SPAWNING` and `SWT_NO_EXIT_TESTS`. This PR also tweaks which bits of `ExitTest` are exposed on platforms that do not support exit tests at all. The type needs to be exposed so that `ExitTest.Result` is exposed so that we can correctly expose `#expect(exitsWith:)` and `#require(exitsWith:)` while marking them unavailable, as opposed to hiding the macros and not giving a developer clear diagnostics.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
briancroom
approved these changes
Oct 18, 2024
stmontgomery
approved these changes
Oct 18, 2024
|
@swift-ci test Linux |
grynspan
deleted the
jgrynspan/SWT_NO_PROCESS_SPAWNING-missing-docs-update
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was supposed to be part of #769, but I must have blown away a local commit because it didn't make it into that PR.
This PR updates Porting.md to explain when a developer might encounter an error due to mismatched
SWT_conditions. It ensures that exit tests require process spawning to be enabled/implemented by adding a dependency betweenSWT_NO_PROCESS_SPAWNINGandSWT_NO_EXIT_TESTS.This PR also tweaks which bits of
ExitTestare exposed on platforms that do not support exit tests at all. The type needs to be exposed so thatExitTest.Resultis exposed so that we can correctly expose#expect(exitsWith:)and#require(exitsWith:)while marking them unavailable, as opposed to hiding the macros and not giving a developer clear diagnostics.Checklist: