Skip to content

Make ExitTestArtifacts.observedValues properly sendable. #781

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Make ExitTestArtifacts.observedValues properly sendable. #781

merged 1 commit into from
Oct 22, 2024

Conversation

grynspan
Copy link
Contributor

I was using nonisolated(unsafe). @stmontgomery reminded me that keypaths can now be conditionally sendable per SE-418.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added bug 🪲 Something isn't working concurrency Swift concurrency/sendability issues tools integration Integration of swift-testing into tools/IDEs exit-tests ☠️ Work related to exit tests labels Oct 22, 2024
@grynspan grynspan self-assigned this Oct 22, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 19329a4 into main Oct 22, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/observedValues-sendable branch October 22, 2024 22:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working concurrency Swift concurrency/sendability issues exit-tests ☠️ Work related to exit tests tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery