Ensure the identifier of a "seen" object is only removed if the object's children were recursively reflected #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's children were recursively reflected Fixes swiftlang#785
stmontgomery
added
bug
stmontgomery
requested review from
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
stmontgomery
commented
Oct 28, 2024
| var objectIdentifierTeRemove: ObjectIdentifier? | ||
| var objectIdentifierToRemove: ObjectIdentifier? |
There was a problem hiding this comment.
Drive by typo and style fixes here and above
suzannaratcliff
approved these changes
Oct 28, 2024
grynspan
approved these changes
Oct 28, 2024
grynspan
added
the
issue-handling
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash which can occur if an object has certain cyclic references and it's included in an expectation expression which fails.
The bug is that the identifier of a "seen" object passed to
Expression.Value.init(_reflecting:label:seenObjects:)should only be removed from the tracking dictionary if the object's children were recursively reflected. If recursion did not occur, that indicates that the object has been seen so it should be left in the tracking dictionary to prevent subsequent recursion. I added new unit tests to validate this.Fixes #785
Result:
The scenarios described in #785 no longer crash.
Checklist: