Specify the module to find the ABI entry point function in (in our own tests). #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tests). The order in which Xcode loads the Apple-vendored copy of Swift Testing vs. a developer-supplied XCTest bundle is unspecified. Our tests assume that the "current" copy of Swift Testing (that is, the copy they linked against) is the first one loaded, which is not always true when running tests in Xcode. The modified tests end up finding the wrong entry point functions when called within Xcode if the load order has changed. This PR explicitly specifies that we are looking for the entry point functions in the module the tests are linked against. Resolves rdar://139140302.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
@swift-ci test |
briancroom
approved these changes
Nov 4, 2024
grynspan
deleted the
jgrynspan/139140302-explicit-module-for-entry-point-lookup-tests
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order in which Xcode loads the Apple-vendored copy of Swift Testing vs. a developer-supplied XCTest bundle is unspecified. Our tests assume that the "current" copy of Swift Testing (that is, the copy they linked against) is the first one loaded, which is not always true when running tests in Xcode. The modified tests end up finding the wrong entry point functions when called within Xcode if the load order has changed.
This PR explicitly specifies that we are looking for the entry point functions in the module the tests are linked against. The change is applied across all platforms that support dynamic linking for the sake of consistency as any of them might have linked a copy of Swift Testing from the toolchain and the package itself.
Resolves rdar://139140302.
Checklist: