Skip to content

Test cleanup: Remove an obsolete fixture suite and add .hidden to a few tests #803

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

stmontgomery
Copy link
Contributor

A few small cleanups to the project's unit tests:

  • Remove the obsolete fixture suite type IndependentlyRunnableTests. The test which used to reference it has been deleted.
  • Add the .hidden trait to a few eligible @Test functions.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added the bug 🪲 Something isn't working label Nov 4, 2024
@stmontgomery stmontgomery self-assigned this Nov 4, 2024
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@@ -439,7 +439,7 @@ private import _TestingInternals
}

#if false // intentionally fails to compile
@Test(arguments: 100 ..< 200)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this test doesn't ever compile. It's useful when testing exit tests to verify what happens if you attempt to close over some state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, understood. Despite being compiled out, without this trait it can still be included in the indexer's test discovery.

@grynspan grynspan added this to the Swift 6.1 milestone Nov 4, 2024
@stmontgomery stmontgomery merged commit 759ce02 into swiftlang:main Nov 4, 2024
3 checks passed
@stmontgomery stmontgomery deleted the test-gardening branch November 4, 2024 18:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants