[SourceKit] Introduce "source.lang.swift.expr.closure" in structure (SR-6116) #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
source.lang.swift.expr.closurein the structure produced by SourceKit. This can be used for tools such as SwiftLint to improve their reliability. One concrete example can be found on this issue.It'd be also useful to know whether a closure is a trailing closure inside a function call, but I'm not sure if it's semantically correct to add this information on this structure, because it's something available in several declarations such as
CallExprandSubscriptExpr, notClosureExpr. I'm also not sure how I would implement this: would I have to usehasTrailingClosurefrom the parent and check if the current closure is the last argument from the parent expression?Resolves SR-6116.