Skip to content

Me too #194

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Me too #194

wants to merge 1 commit into from

Conversation

SwiftLover
Copy link

Hyphenated made up words

Hyphenated made up words
@@ -153,8 +153,8 @@ A tuple type's access level is the minimum of the access levels of its
elements. A function type's access level is the minimum of the access levels of
its input and return types.

A typealias may have any access level up to the access level of the type it
aliases. That is, a ``private`` typealias can refer to an ``public`` type, but
A type-alias may have any access level up to the access level of the type it
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't typealias (one word) already a Swift keyword? I think this makes sense to leave as-is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apples own documentation breaks it into two words https://developer.apple.com/library/prerelease/ios/documentation/Swift/Conceptual/Swift_Programming_Language/Declarations.html

So if anything the hyphen should be removed.

@jrose-apple
Copy link
Contributor

Hm. The compiler's not really consistent with the formal docs on this already, and I'm a little iffy about "type alias" sounding like a general term instead of specifically referring to what you get from a standalone typealias. I think I'd rather leave this as is. Thanks, though.

@jrose-apple jrose-apple closed this Dec 4, 2015
dabelknap added a commit to dabelknap/swift that referenced this pull request Jan 23, 2019
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Add 4.2 configuration to project_precommit_check
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants