-
Notifications
You must be signed in to change notification settings - Fork 10.5k
build-script: support CMake install steps. #27886
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
build-script: support CMake install steps. #27886
Conversation
Currently, bots that perfrom an installation will build LLDB once using CMake because that is the default and then again using Xcode because the CMake install step is not implemented by build-script. This patch adds CMake support by calling the generic cmake install-lldb step. <rdar://problem/51317901> (cherry picked from commit 78218b0)
@swift-ci please test |
@swift-ci build toolchain macOS |
Build failed |
@swift-ci test linux |
Build failed |
@swift-ci test linux |
macOS Toolchain Install command |
Build failed |
The linux build is failing with some unrelated error? 7:52:42 2019-10-26 00:52:42.813 SourceKitLSPPackageTests.xctest[93680:f67fc700] manifest parse error(s): |
I had it run the linux build twice, both failed, I can't remember if it was the same error both times tho. |
@swift-ci test Linux |
Build failed |
Looks like repl_swift is missing |
I was able to reproduce the failure of the bot on my machine and confirm a more direct fix for it; I'm going to see how that PR passes all the bots and commit that if it looks good, doing that in swiftlang/llvm-project#42 |
Test with PR: @swift-ci test build toolchain |
Test with PR: @swift-ci build toolchain |
macOS Toolchain Install command |
@jasonmolenda Looks like it failed on Linux, with missing
|
Yeah my plan is to solve this with the more direct fix in swiftlang/llvm-project#42 --- I don't want to bother messing with this fix if I don't need to. |
Cherry-pick Adrian's fix from master to skip an unnecessary xcodebuild invocation;
should fix the swift-5.1 bot problem eg https://ci.swift.org/job/oss-swift-5.1-package-osx/
build-script: support CMake install steps.
Currently, bots that perfrom an installation will build LLDB once using CMake
because that is the default and then again using Xcode because the CMake
install step is not implemented by build-script. This patch adds CMake support
by calling the generic cmake install-lldb step.
rdar://problem/51317901
(cherry picked from commit 78218b0)