Skip to content

build-script: support CMake install steps. #27886

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

jasonmolenda
Copy link
Contributor

Cherry-pick Adrian's fix from master to skip an unnecessary xcodebuild invocation;
should fix the swift-5.1 bot problem eg https://ci.swift.org/job/oss-swift-5.1-package-osx/

build-script: support CMake install steps.

Currently, bots that perfrom an installation will build LLDB once using CMake
because that is the default and then again using Xcode because the CMake
install step is not implemented by build-script. This patch adds CMake support
by calling the generic cmake install-lldb step.

rdar://problem/51317901

(cherry picked from commit 78218b0)

Currently, bots that perfrom an installation will build LLDB once using CMake
because that is the default and then again using Xcode because the CMake
install step is not implemented by build-script. This patch adds CMake support
by calling the generic cmake install-lldb step.

<rdar://problem/51317901>

(cherry picked from commit 78218b0)
@jasonmolenda jasonmolenda requested a review from a team as a code owner October 25, 2019 21:11
@jasonmolenda
Copy link
Contributor Author

@swift-ci please test

@shahmishal
Copy link
Member

@swift-ci build toolchain macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 529e7fd

@jasonmolenda
Copy link
Contributor Author

@swift-ci test linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 529e7fd

@jasonmolenda
Copy link
Contributor Author

@swift-ci test linux

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 529e7fd

Install command
tar -zxf swift-PR-27886-405-osx.tar.gz --directory ~/

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 529e7fd

@jasonmolenda
Copy link
Contributor Author

The linux build is failing with some unrelated error?

7:52:42 2019-10-26 00:52:42.813 SourceKitLSPPackageTests.xctest[93680:f67fc700] manifest parse error(s):
17:52:42
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.1-branch/tmp/TemporaryDirectory.PFxAzl/pkg/Package.swift:3:5: error: type annotation missing in pattern
17:52:42 let pack
17:52:42 ^

@jasonmolenda
Copy link
Contributor Author

I had it run the linux build twice, both failed, I can't remember if it was the same error both times tho.

@shahmishal
Copy link
Member

@swift-ci test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 529e7fd

@shahmishal
Copy link
Member

14:47:30 lit.py: /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.1-branch/swift-integration-tests/lit.cfg:189: note: testing using 'repl_swift': /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.1-branch/buildbot_linux/none-swift_package_sandbox_linux-x86_64/usr/bin/repl_swift
14:47:30 lit.py: /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-swift-5.1-branch/swift-integration-tests/lit.cfg:205: fatal: repl_swift does not exist!

Looks like repl_swift is missing

@jasonmolenda
Copy link
Contributor Author

I was able to reproduce the failure of the bot on my machine and confirm a more direct fix for it; I'm going to see how that PR passes all the bots and commit that if it looks good, doing that in swiftlang/llvm-project#42

@jasonmolenda
Copy link
Contributor Author

Test with PR:
swiftlang/llvm-project#42

@swift-ci test build toolchain

@shahmishal
Copy link
Member

Test with PR:
swiftlang/llvm-project#42

@swift-ci build toolchain

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 529e7fd

Install command
tar -zxf swift-PR-27886-408-osx.tar.gz --directory ~/

@shahmishal
Copy link
Member

@jasonmolenda Looks like it failed on Linux, with missing repl_swift file.

'repl_swift': /home/buildnode/jenkins/workspace/swift-PR-toolchain-Linux/branch-swift-5.1-branch/buildbot_linux/none-swift_package_sandbox_linux-x86_64/usr/bin/repl_swift
19:03:33 lit.py: /home/buildnode/jenkins/workspace/swift-PR-toolchain-Linux/branch-swift-5.1-branch/swift-integration-tests/lit.cfg:205: fatal: repl_swift does not exist!

@jasonmolenda
Copy link
Contributor Author

@jasonmolenda Looks like it failed on Linux, with missing repl_swift file.

'repl_swift': /home/buildnode/jenkins/workspace/swift-PR-toolchain-Linux/branch-swift-5.1-branch/buildbot_linux/none-swift_package_sandbox_linux-x86_64/usr/bin/repl_swift
19:03:33 lit.py: /home/buildnode/jenkins/workspace/swift-PR-toolchain-Linux/branch-swift-5.1-branch/swift-integration-tests/lit.cfg:205: fatal: repl_swift does not exist!

Yeah my plan is to solve this with the more direct fix in swiftlang/llvm-project#42 --- I don't want to bother messing with this fix if I don't need to.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants