Skip to content

[WebAssembly] Add no-op MutexWASI.h implementation #29459

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2020
Merged

[WebAssembly] Add no-op MutexWASI.h implementation #29459

merged 2 commits into from
Jan 29, 2020

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 26, 2020 •
edited
Loading

Since WebAssembly doesn't support threading, no locking is done in runtime. This PR adds a no-op implementation in MutexWASI.h to improve compatibility with WASI.

This is a part of SR-9307 and #24684.

(cc @kateinoigakukun @zhuowei)

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Jan 26, 2020 •
edited
Loading

@jrose-apple @stephentyrone @tbkka would any of you be available for a review please? Otherwise should I request it from anyone else? Thanks!

gribozavr
gribozavr requested changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@gribozavr gribozavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small change to the comment.

include/swift/Runtime/MutexWASI.h Outdated
//
//===----------------------------------------------------------------------===//
//
// Stub implementation of Mutex, ConditionVariable, Read/Write lock, and Scoped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/stub/no-op/

I wouldn't say "no concrete implementation is provided" because it is a concrete implementation, it just does not perform locking.

"No-op implementation of locks for the WebAssembly System Interface. The implementation does not need to perform locking, because as of <insert WebAssembly spec version, or today's date> WebAssembly does not support threads."

@MaxDesiatov MaxDesiatov requested a review from gribozavr January 26, 2020 21:51
gribozavr
gribozavr approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@gribozavr gribozavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxDesiatov
Copy link
Contributor Author

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Contributor Author

@gribozavr could you trigger a CI run here? Thank you!

@gribozavr
Copy link
Contributor

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Jan 27, 2020 •
edited
Loading

@gribozavr I don't think PackageDescription4LoadingTests.testUnavailableAPIs test failure at this line could be related, is this some kind of a temporary problem or a sporadic issue? Would retriggering CI help?

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd compnerd merged commit 7392c8d into swiftlang:master Jan 29, 2020
@compnerd
Copy link
Member

@MaxDesiatov in the future, please keep fixups to the change in a single commit in the future.

@MaxDesiatov MaxDesiatov deleted the swiftwasm-mutex branch January 29, 2020 07:14
@MaxDesiatov MaxDesiatov mentioned this pull request Feb 17, 2020
Closed
78 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gribozavr gribozavr gribozavr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @gribozavr @compnerd