Skip to content

[Runtime] Define WASI MutexPThread macros as 0 #31678

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 9, 2020

Conversation

MaxDesiatov
Copy link
Contributor

WebAssembly/WASI target doesn't compile with MutexPThread constexpr macros defined as 1 due lack of support for threading/locking, previously reported in SR-12097.

Related to SR-9307.

@MaxDesiatov MaxDesiatov changed the title [Runtime] Define WebAssembly/WASI MutexPThread macros as 0 [Runtime] Define WASI MutexPThread macros as 0 May 9, 2020
@MaxDesiatov
Copy link
Contributor Author

@CodaFi would you like a separate SR for this one too?

@CodaFi
Copy link
Contributor

CodaFi commented May 9, 2020

This one’s fine as-is.

@swift-ci smoke test

@CodaFi CodaFi merged commit 9eb4079 into swiftlang:master May 9, 2020
@MaxDesiatov MaxDesiatov deleted the patch-2 branch May 10, 2020 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants