Skip to content

IRGen: Simplify logic for locating the legacy type info YAML file #32930

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

slavapestov
Copy link
Contributor

This will eliminate the unhelpful "Cannot read ‘/usr/lib/swift/layouts-x86_64.yaml’"
error message, and actually print the location where the file was supposed to be
found.

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

This will eliminate the unhelpful "Cannot read ‘/usr/lib/swift/layouts-x86_64.yaml’"
error message, and actually print the location where the file was supposed to be
found.
@slavapestov slavapestov force-pushed the simplify-legacy-type-info branch from 0b29ab1 to 0b884c8 Compare July 16, 2020 20:09
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0b29ab10afd6fd0043308b2eced2cdef14764ebd

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0b29ab10afd6fd0043308b2eced2cdef14764ebd

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0b29ab10afd6fd0043308b2eced2cdef14764ebd

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0b884c8

@slavapestov
Copy link
Contributor Author

Still seeing a Linux test failure in 'AutoDiff/validation-test/differentiable_protocol_requirements.swift':

8:48:18 swift-frontend: /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/lib/SIL/IR/SILInstructions.cpp:2436: static swift::ConvertFunctionInst *swift::ConvertFunctionInst::create(swift::SILDebugLocation, swift::SILValue, swift::SILType, swift::SILFunction &, swift::SILOpenedArchetypesState &, bool): Assertion `opTI->isABICompatibleWith(resTI, F).isCompatible() && "Can not convert in between ABI incompatible function types"' failed.
18:48:18 Stack dump:
18:48:18 0.	Program arguments: /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend -frontend -c -primary-file /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/AutoDiff/validation-test/differentiable_protocol_requirements.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-cache-path /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache -swift-version 4 -O -ignore-module-source-info -module-name main -o /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/differentiable_protocol_requirements-24dbaa.o 
18:48:18 1.	Swift version 5.3-dev (LLVM e3586932cc1c511, Swift 50583dca47dfeda)
18:48:18 2.	While evaluating request ExecuteSILPipelineRequest(Run pipelines { PrepareOptimizationPasses, EarlyModulePasses, HighLevel,Function+EarlyLoopOpt, HighLevel,Module+StackPromote, Serialize, MidLevel,Function, ClosureSpecialize, LowLevel,Function, LateLoopOpt, SIL Debug Info Generator } on SIL for main.main)
18:48:18 3.	While running pass #17491 SILFunctionTransform "Devirtualizer" on SILFunction "@$s0131AD__$s4main11derivatives2at2in23DifferentiationUnittest7TrackedVySfG_A3HtAH_xmtAA12FunctionsOfXRzlFA2HcfU___vjp_src_0_wrt_0_4main12mnO04main04TestmN1XV_Tg5".
18:48:18  for expression at [/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/AutoDiff/validation-test/differentiable_protocol_requirements.swift:104:30 - line:104:47] RangeText="{ x in F(x: x).x "
18:48:18  #0 0x0000000005739d04 PrintStackTraceSignalHandler(void*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x5739d04)
18:48:18  #1 0x0000000005737800 llvm::sys::RunSignalHandlers() (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x5737800)
18:48:18  #2 0x0000000005739ffa SignalHandler(int) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x5739ffa)
18:48:18  #3 0x00007fc125757390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
18:48:18  #4 0x00007fc1242d6428 raise (/lib/x86_64-linux-gnu/libc.so.6+0x35428)
18:48:18  #5 0x00007fc1242d802a abort (/lib/x86_64-linux-gnu/libc.so.6+0x3702a)
18:48:18  #6 0x00007fc1242cebd7 (/lib/x86_64-linux-gnu/libc.so.6+0x2dbd7)
18:48:18  #7 0x00007fc1242cec82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
18:48:18  #8 0x0000000001143ff7 swift::ConvertFunctionInst::create(swift::SILDebugLocation, swift::SILValue, swift::SILType, swift::SILFunction&, swift::SILOpenedArchetypesState&, bool) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x1143ff7)
18:48:18  #9 0x0000000000c9fe62 swift::castValueToABICompatibleType(swift::SILBuilder*, swift::SILLocation, swift::SILValue, swift::SILType, swift::SILType) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xc9fe62)
18:48:18 #10 0x0000000000c80461 replaceApplySite(swift::SILBuilder&, swift::SILLocation, swift::ApplySite, swift::SILValue, swift::SubstitutionMap, llvm::ArrayRef<swift::SILValue>, swift::SILFunctionConventions, llvm::ArrayRef<swift::SILValue>) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xc80461)
18:48:18 #11 0x0000000000c812d9 swift::tryDevirtualizeWitnessMethod(swift::ApplySite, swift::OptRemark::Emitter*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xc812d9)
18:48:18 #12 0x0000000000c819fd swift::tryDevirtualizeApply(swift::ApplySite, swift::ClassHierarchyAnalysis*, swift::OptRemark::Emitter*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xc819fd)
18:48:18 #13 0x0000000000b813e2 (anonymous namespace)::Devirtualizer::run() (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xb813e2)
18:48:18 #14 0x0000000000abae84 swift::SILPassManager::runPassOnFunction(unsigned int, swift::SILFunction*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xabae84)
18:48:18 #15 0x0000000000abbd1b swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xabbd1b)
18:48:18 #16 0x0000000000abee0e swift::SILPassManager::execute() (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xabee0e)
18:48:18 #17 0x0000000000ab90a8 swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xab90a8)
18:48:18 #18 0x0000000000ab906c swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xab906c)
18:48:18 #19 0x0000000000ad525b swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xad525b)
18:48:18 #20 0x0000000000ac3f61 llvm::Expected<swift::ExecuteSILPipelineRequest::OutputType> swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest>(swift::ExecuteSILPipelineRequest const&) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xac3f61)
18:48:18 #21 0x0000000000ab9275 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xab9275)
18:48:18 #22 0x0000000000ac6ea8 swift::runSILOptimizationPasses(swift::SILModule&) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0xac6ea8)
18:48:18 #23 0x000000000068345b swift::CompilerInstance::performSILProcessing(swift::SILModule*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x68345b)
18:48:18 #24 0x000000000050e56f performCompileStepsPostSILGen(swift::CompilerInstance&, std::unique_ptr<swift::SILModule, std::default_delete<swift::SILModule> >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x50e56f)
18:48:18 #25 0x00000000004ffbdd swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x4ffbdd)
18:48:18 #26 0x000000000047ce1b main (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x47ce1b)
18:48:18 #27 0x00007fc1242c1830 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x20830)
18:48:18 #28 0x000000000047c8d9 _start (/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swift-frontend+0x47c8d9)

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0b884c8

@slavapestov
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0b884c8

@slavapestov
Copy link
Contributor Author

@swift-ci Please clean test Linux

@slavapestov slavapestov merged commit 506aa1d into swiftlang:master Jul 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants