-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Platform: add sys_xattr
module for Android
#74742
Conversation
@swift-ci please test |
@compnerd could you also include it from |
Sure, though could you explain why that is needed? |
This module was left out from the modulariation pass. The declarations here are required for building swift-foundation for Android.
@swift-ci please test |
I haven't tried building the new |
I've tested the android build locally, and this is needed to make progress on the swift-foundation builds for Android. Additionally, the introduced module is an explicit module which was previously not included, so I do not expect this to cause any regressions. |
I don't either, just running the compiler validation suite with it natively on Android now. |
Alright, ran the full compiler validation suite natively on Android with this pull and am building a full trunk toolchain with it now, don't see any issues. |
Okay, would be nice to merge this for now. We can address any issues subsequently. Hopefully we can get to the point where we can get swift-foundation android builds via cross-compilation in CI as well. Or would you rather report back quickly @finagolfin? |
If you need it to build
I don't understand: what do you want me to report back about? |
Oh, I thought you were doing more tests. Going to merge! |
This module was left out from the modulariation pass. The declarations here are required for building swift-foundation for Android.