Skip to content

[6.1] Revert some changes to CSBinding that landed after branch was created #78305

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2024
Merged

[6.1] Revert some changes to CSBinding that landed after branch was created #78305

merged 4 commits into from
Dec 21, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 19, 2024 •
edited
Loading

Reverts #76487, #77153 and #76952

xedin added 4 commits December 19, 2024 14:36
@xedin
[CSBindings] Revert changes in BindingSet::isViable
9bf11bc 
This change although correct cases performance issues
in some scenarios.

(cherry picked from commit d01c9cb)
@xedin
Revert "[CSBindings] Don't favor application result types before appl…
fc26ad3 
…ication happens"

This reverts commit bc949c3.

(cherry picked from commit 8aa6280)
@xedin
Revert "[CSBindings] Adjust hasConversions to handle Void has hav…
c7fb93d 
…ing not conversions"

This reverts commit 76f0bcb.

(cherry picked from commit ffac97a)
@xedin
[Tests] NFC: Bring back test-case that makes sure that closures disca…
c55c2b6 
…rd result correctly

(cherry picked from commit 92a1b1f)
@xedin xedin requested a review from a team as a code owner December 19, 2024 22:42
@xedin
Copy link
Contributor Author

xedin commented Dec 19, 2024

@swift-ci please test

@xedin xedin requested a review from airspeedswift December 19, 2024 22:44
@xedin
Copy link
Contributor Author

xedin commented Dec 20, 2024

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Dec 20, 2024

@swift-ci please test

@xedin xedin merged commit 12fb6cb into swiftlang:release/6.1 Dec 21, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @bnbarham