Skip to content

[CSOptimizer] Literal arguments should cause score reset only for operators #78526

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 9, 2025

Resetting score to 0.1 is intended to make sure that the
solver picks the outermost disjunction in literal chains like
1 + 2 + 3 ... because that would provide context to the
inner choices.

Resolves: #78371
Resolves: rdar://142105691

xedin added 2 commits January 9, 2025 10:39
…rators

Resetting score to `0.1` is intended to make sure that the
solver picks the outermost disjunction in literal chains like
`1 + 2 + 3 ...` because that would provide context to the
inner choices.

Resolves: swiftlang#78371
Resolves: rdar://142105691
@xedin
Copy link
Contributor Author

xedin commented Jan 9, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 10, 2025

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jan 10, 2025

@swift-ci please test source compatibility release

@xedin xedin merged commit 84c7188 into swiftlang:main Jan 13, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A unicode scalar initialization now errors about overflow since the Dec. 19 trunk snapshot
1 participant