Skip to content

Revert "[Concurrency] Provide a Swift interface for custom main and global executors." #80224

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

Revert "[Concurrency] Provide a Swift interface for custom main and global executors." #80224

merged 1 commit into from
Mar 22, 2025

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Mar 22, 2025 •
edited
Loading

Rebased #80194 to unblock CI.
(reverts #79789, and also effectively reverts #80201.)

@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

@swift-ci please smoke test windows platform

@glessard
Copy link
Contributor Author

@swift-ci please test Windows platform

@compnerd compnerd mentioned this pull request Mar 22, 2025
Closed
@compnerd compnerd enabled auto-merge March 22, 2025 17:37
@compnerd
Copy link
Member

Not sure if this is a flake, but the following test failed:

Swift(windows-x86_64) :: IRGen/async/run-thintothick-int64-to-void.sil

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@compnerd
Copy link
Member

Tried to ping @drexin as build wrangler - we should get this merged to get CI healthy again

@drexin drexin disabled auto-merge March 22, 2025 20:49
@drexin drexin merged commit 06f6358 into swiftlang:main Mar 22, 2025
2 of 3 checks passed
al45tair added a commit to al45tair/swift that referenced this pull request Mar 24, 2025
@al45tair
Revert "Merge pull request swiftlang#80224 from glessard/revert-79789…
f53d3ca 
…-custom-executors"

This reverts commit 06f6358, reversing
changes made to 033f667.
@al45tair al45tair mentioned this pull request Mar 24, 2025
Closed
@glessard glessard deleted the revert-79789-custom-executors branch March 24, 2025 15:49
al45tair added a commit to al45tair/swift that referenced this pull request Mar 25, 2025
@al45tair
Revert "Merge pull request swiftlang#80224 from glessard/revert-79789…
a9f934d 
…-custom-executors"

This reverts commit 06f6358, reversing
changes made to 033f667.
al45tair added a commit to al45tair/swift that referenced this pull request Mar 28, 2025
@al45tair
Revert "Merge pull request swiftlang#80224 from glessard/revert-79789…
b2b988a 
…-custom-executors"

This reverts commit 06f6358, reversing
changes made to 033f667.
al45tair added a commit to al45tair/swift that referenced this pull request Mar 28, 2025
@al45tair
Revert "Merge pull request swiftlang#80224 from glessard/revert-79789…
47fa717 
…-custom-executors"

This reverts commit 06f6358, reversing
changes made to 033f667.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glessard @compnerd @drexin @al45tair