-
Notifications
You must be signed in to change notification settings - Fork 30
Support Amazon Linux 2 for SwiftWasm distribution #2654
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
f767da9
to
92c5612
Compare
Does this fully resolve #2318? |
Yes 👍 |
Do you think that we'll be able to build it within a Docker image on GitHub Actions, or do we need a real Amazon EC2 VM to get CI set up for this? |
756ce6c
to
92669a8
Compare
I think we don't need EC2 instance and it can be built on Docker on GitHub Actions. |
72d7c76
to
c3b6ecf
Compare
c3b6ecf
to
1e22805
Compare
Hmm, it seems impossible to build toolchain for amazonlinux2 on docker on GitHub Actions due to the time limit 😢 |
b09c8a5
to
42daf2a
Compare
42daf2a
to
9d4f91f
Compare
@MaxDesiatov It's ready to merge. This build pipeline can be also used for M1 toolchain, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit 👍
Is there an easy way to observe logs, test results, and download distributions for a given CI run on the buildbot?
@MaxDesiatov You can see logs in https://github.com/swiftwasm/swiftwasm-buildbot/actions |
* Support Amazon Linux 2 for SwiftWasm distribution * Setup Amazon Linux CI * Refactoring CI script * Fetch merge commit from GitHub * Rename ci yaml file * Fix e2e preparation script * Add missing swift-crypto info for checking out * Stop build toolchain for amazonlinux on CI * Update actions/checkout to v2 * Remove duplicated unzip from distribution script * Checkout with given scheme * Dispatch buildbot repo event after creating a new tag * Add branch name as workflow input * Use actions/checkout v2 * Use SWIFTWASM_BUILDBOT_TOKEN to trigger buildbot ci
We can build the toolchain with below Dockerfile