-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update config.yml #2
Conversation
Nice work getting this pull request opened! This pull request updates the All projects have different needs, ranging from standard unit tests to custom configuration. Regardless of the definition of "success" for your project, this is the place to define it. There isn't much in this file right now, but we're going to change that. We'll make a change to configure the build environment. Notice that this configuration file includes a Docker image to execute the build, defining the environment. There's also a CircleCI is only triggered by new commits. To trigger CircleCI, add the below text in place of the githubtraining/ci-custom:latest Step 3: Specify the Docker imageTo get the CI build to succeed, replace the placeholder text and commit the change. ⌨️ Activity: Select a specific configuration
I'll respond below with your next step.
|
Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Soon, your CI build should succeed! 🎉
When the build completes, notice that your pull request shows all checks have passed with 1 successful check. If it isn't showing up green in a few minutes, try refreshing the page. To see more details, you can click "See all checks".
Why did my CI build succeed?
The .circleci/config.yml
file defines your build environment and tests. This important config.yml
file defines the entire delivery process. Your CI build will succeed if:
- The
.circleci/config.yml
file is present - Your commit passes the tests as outlined in the
config.yml
file
Ensuring quality
Tests can be an important contributing factor to ensuring quality, but they're still only a piece of the puzzle. Integrations like CircleCI offer the most benefit with quality, high coverage tests.
No matter how well written your tests are, tests work best when paired with thorough review. Remember that all tests are most effective when paired with pull request reviews. To learn more about reviews on GitHub, take a look at the Reviewing pull requests Learning Lab course.
Step 4: Merge the configuration
Now that our CI build is succeeding, merge this pull request so the .circleci/config.yml
file is present on the main
branch.
⌨️ Activity: Share your configuration with the team by merging it
- Click Merge pull request.
- Delete your branch.
I'll respond below with your next step.
Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response, wait a few seconds and refresh the page for your next steps.
The Now that your CI build is succeeding, let's add some validations to your project. I've opened a new pull request for your next steps.
|
Change added