Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid usage of metrics where a history is kept #609

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

dominik-cnx
Copy link
Collaborator

Refer to

https://github.com/swisspost/mod-metrics/blob/develop/src/main/java/org/swisspush/metrics/MetricsModule.java#L86-L106

The purpose of this PR is to find out we use a Gauge instead of a Histogram for "duration" metrics and also for some queue counter in order to reduce the memory foot print. The impact will be that we only have a simple counter here

image

compared to

image

@dominik-cnx dominik-cnx requested review from Kusig and mcweba September 18, 2024 03:22
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.44%. Comparing base (5256fe4) to head (45f39c1).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...isspush/gateleen/monitoring/MonitoringHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #609      +/-   ##
=============================================
- Coverage      48.79%   48.44%   -0.36%     
+ Complexity      1877     1862      -15     
=============================================
  Files            238      238              
  Lines          11953    11953              
  Branches        1261     1261              
=============================================
- Hits            5833     5791      -42     
- Misses          5616     5659      +43     
+ Partials         504      503       -1     
Flag Coverage Δ
48.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominik-cnx dominik-cnx merged commit 231a50b into develop Sep 23, 2024
4 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants