Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug 618 response handler in forwarder called twice per request #620

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bug 618 response handler in forwarder called twice per request #620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d7b213
Not adding response handler twice anymore.
hoetdr-post Dec 17, 2024
5f0349e
Added the response handler before, instead of only at the time we sen…
hoetdr-post Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gateleen-routing/src/main/java/org/swisspush/gateleen/routing/Forwarder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ public void handle(AsyncResult<HttpClientRequest> event) {
*/
if (bodyData == null) {

// Gateleen internal requests (e.g. from scedulers or delegates) often have neither "Content-Length" nor "Transfer-Encoding: chunked"
// Gateleen internal requests (e.g. from schedulers or delegates) often have neither "Content-Length" nor "Transfer-Encoding: chunked"
// header - so we must wait for a body buffer to know: Is there a body or not? Only looking on the headers and/or the http-method is not
// sustainable to know "has body or not"
// But: if there is a body, then we need to either setChunked or a Content-Length header (otherwise Vertx complains with an Exception)
Expand Down Expand Up @@ -444,16 +444,16 @@ public WriteStream<Buffer> drainHandler(@Nullable Handler<Void> handler) {
// Setting the endHandler would then lead to an Exception
// see also https://github.com/eclipse-vertx/vert.x/issues/2763
// so we now check if the request already is ended before installing an endHandler
cReq.send(cResHandler);
cReq.send();
} else {
req.endHandler(v -> cReq.send(cResHandler));
req.endHandler(v -> cReq.send());
pump.start();
}
} else {
loggingHandler.appendRequestPayload(bodyData);
// we already have the body complete in-memory - so we can use Content-Length header and avoid chunked transfer
cReq.putHeader(HttpHeaders.CONTENT_LENGTH, Integer.toString(bodyData.length()));
cReq.send(bodyData, cResHandler);
cReq.send(bodyData);
}

loggingHandler.request(cReq.headers());
Expand Down
Loading