Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: prevent fetching large block range #21

Merged
merged 6 commits into from
Apr 4, 2024
Merged

fix: prevent fetching large block range #21

merged 6 commits into from
Apr 4, 2024

Conversation

mpetrun5
Copy link
Contributor

@mpetrun5 mpetrun5 commented Apr 3, 2024 •
edited
Loading

Avoid fetching block range larger than 1000 block to prevent RPC errors.

Description

Related Issue Or Context

Closes: #20

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Go Test coverage is 89.1 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Go Test coverage is 89.1 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit bc4db01 into main Apr 4, 2024
9 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/prevent-fetching-large-block-range branch April 4, 2024 10:30
@mpetrun5 mpetrun5 mentioned this pull request Apr 4, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid fetching too large block range
2 participants
@mpetrun5 @MakMuftic