Finality proof fix #253
Merged
Finality proof fix #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfaultxavi
requested changes
Dec 2, 2020
| @@ -5,6 +5,9 @@ required: | |||
| - hashes | |||
| - signatures | |||
| properties: | |||
| signatureSchema: | |||
| description: Signature schema. | |||
There was a problem hiding this comment.
Not a very useful description, specially when the type is an integer. How is the user supposed to know what to do with this number?
There was a problem hiding this comment.
SignatureSchema is removed in public net (main branch).
There was a problem hiding this comment.
only returned from server, user won't need to provide it
rg911
added a commit
that referenced
this pull request
Dec 8, 2020
* Updated lock secret endpoints * Added transactions transferMosaicId filter * Creating new version 0.10.1 * Added endpoints to get finalization proof at a given height or point * Point to Epoch and redesigned routes * Added DTOs * Made epoch endpoint clearer * Renamed a field, added some descriptions * Update spec/core/finalization/schemas/MessageGroup.yml Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> * Update spec/core/finalization/routes/getFinalizationProofAtEpoch.yml * Fixed missing index entries * Updated epoch/point types * Added transfer amount options to filter transfer transactions * Updated transferMosaicId param description Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> * Typo * Fixed filter type * Improved search transactions endpoint description regarding alias resolution and addresses (#231) Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> * Removed id from namespace meta This field has been moved to the top-level https://github.com/nemtech/symbol-openapi/blob/main/spec/plugins/namespace/schemas/NamespaceInfoDTO.yml#L3 * unlocke account (#243) * Added new node public key (#244) * Merkle endpoints for state proof (#240) * POC merkle endpoints Renamed Status to LockStatus enum * Updated Merkle Info name and description * Added missing endpoints * Added missing params * Add new block type (#247) * Add new block type * Added missing export * Added Uint64 to simplify generation. Co-authored-by: fernando <fboucquez@gmail.com> * Added merkle tree schema (#248) Co-authored-by: fboucquez <fboucquez@gmail.com> Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> * Added version to states (#252) * Added missing failure status (#250) * Added missing failure status * Added a few more missing statuses * Moved Roles types to a generic number (#258) * Updated network types (#257) * Finality proof fix (#253) * Finality proof fix * Updated signatureSchema desc * Namespace Transaction required fields fix (#242) On namespace transactions, duration or parent id is required, but not both at the same time. If required is in place, user (and generated code) would think that duration and parentid are always provided. * Updated version and CHANGELOG.md (#254) * Update CHANGELOG.md (#259) Co-authored-by: Martin Ayora <martin.ayora@nem.software> Co-authored-by: Travis CI User <travis@example.org> Co-authored-by: Roger Hernandez <rogerernandez@hotmail.com> Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es> Co-authored-by: Steven Liu <xian.f.liu@gmail.com> Co-authored-by: Martin Ayora <17176539+martinayora@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finality proof fix