Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark subs as throwing exceptions #487

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jul 25, 2024

No description provided.

@isuruf isuruf mentioned this pull request Jul 25, 2024
@bjodah
Copy link
Contributor

bjodah commented Aug 3, 2024

+1 from me. Only comment (nitpick): would ValueError be more appropriate than RuntimeError?

Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjodah bjodah merged commit fa9d699 into symengine:master Aug 12, 2024
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants