fix: Allow array arguments in model.options
#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
added
Bug
chr-hertel
changed the title
model.options (#103)model.options
Nyholm
reviewed
Jul 12, 2025
chr-hertel
force-pushed
the
allow-array-options
branch
3 times, most recently
from
0766991 to
ecdb49d
Compare
OskarStark
approved these changes
Jul 12, 2025
Nyholm
approved these changes
Jul 12, 2025
|
Needs rebase @chr-hertel |
Allow array arguments in `model.options`
chr-hertel
force-pushed
the
allow-array-options
branch
from
ecdb49d to
0082388
Compare
|
Thank you @valtzu. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking php-llm/llm-chain-bundle#103