Skip to content

Add option to specify version in add lines requires #1055

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented May 29, 2025

Currently, when requiring symfony/panther, Flex adds the following two lines to phpunit.dist.xml:

<extensions>
+    <bootstrap class="Symfony\Component\Panther\ServerExtension" />
+    <extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>

This isn't entirely correct: the extension tag is used for PHPUnit <10, while bootstrap is used for PHPUnit >=10.

This PR adds support for specifying the required package version for each line, so only the appropriate one is added.

Recipes PR: symfony/recipes#1422

@HypeMC HypeMC force-pushed the add-version-to-add-lines-requires branch from 24b10a8 to 3319fcf Compare May 29, 2025 18:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant