Skip to content

Commit

Permalink
Merge branch '5.4' into 6.4
Browse files Browse the repository at this point in the history
* 5.4:
  do not mix named and positional arguments in data provider definitions
  session names must not be empty
  fix Contracts directory name in PHPUnit configuration
  Passing null to parameter #2 ($subject) of type string is deprecated
  • Loading branch information
xabbuh committed Oct 11, 2024
2 parents 3363819 + 35f7b4c commit 4c0341b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function testUseSessionGcMaxLifetimeAsTimeToLive()

public function testDestroySession()
{
$this->storage->open('', '');
$this->storage->open('', 'test');
$this->redisClient->set(self::PREFIX.'id', 'foo');

$this->assertTrue((bool) $this->redisClient->exists(self::PREFIX.'id'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function testWriteSessionWithLargeTTL()

public function testDestroySession()
{
$this->storage->open('', '');
$this->storage->open('', 'sid');
$this->memcached
->expects($this->once())
->method('delete')
Expand Down

0 comments on commit 4c0341b

Please # to comment.