-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[make:*] add single_text
widget for all date types
#1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @tacman! Thank you.. Can you rebase this please and we'll get it merged in.
A bit embarrassing, but I don't know how to do a rebase. What do I need to do? |
No worries.. You should see me hunt for my post its when trying to remember how to add commits to someone else's pr Assuming locally your remotes look something like:
You may encounter an error or 2 that say hey! you need to fix a conflict. If you're using PHPStorm - i recommend fixing them in there. Otherwise you'll be diving into After you resolve any conflicts ->
double check the git log before adding the
Further reading: https://symfony.com/doc/current/contributing/code/pull_requests.html#work-on-your-pull-request |
As a side note for anyone that stumble on this.. never do a Only rebase on code / branches you own and not code that someone else could be using... Git rebase essentially changes history on the branch you're rebasing... thats not always good... |
ee109e8
to
6eb66ca
Compare
single_text
widget for all date types
Because there are many date types, I used to the helper to get the mapping and checked for those.
Fixes #1392