[make:registration] use "User" type in EmailVerifier::class
#1519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendEmailConfirmation()
&&handleEmailConfirmation()
both have the$user
type asUserInterface
. This is pointless other than to ensure we get a "user" object. Seeing as we already know the class details of the "user" object, let's use the class short name instead ofUserInterface
when generatingEmailVerifier
. Improves phpstan in userland.(string)
cast togetId()
calls on the user object. In cases where the users id is anint
, this will squash any squawks from phpstan aboutEdge Case
If the consumer has multiple "user" objects that use these methods (out of scope for MakerBundle), they can change the type manually to either
User|AnotherUser $user
||CustomUserInterface $user
.