Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ci] temp. skip API Platform tests - recipe conflict #1598

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jrushlow
Copy link
Collaborator

Unable to run make:entity tests that require api-platform as a dependency. API Platform v3.4 does not allow for api_platform.keep_legacy_inflector to be set, but it's automatically included in <3.4 recipe(s). No recipe exists yet for >=3.4.

Skipped Test Cases:

  • it_creates_a_new_class_and_api_resource
  • it_makes_new_entity_no_to_all_extras

Tests to be re-enabled once symfony/recipes#1339 is merged.


There are more complex ways to restrict these 2 test cases to run on =<3.3 - but this is the easiest path forward at the moment.

@jrushlow jrushlow added the Minor Minor Enhancement label Sep 25, 2024
@jrushlow jrushlow merged commit 3cf70d8 into symfony:main Sep 25, 2024
9 checks passed
@jrushlow jrushlow deleted the ci/skip-api-test-tmp branch September 25, 2024 09:18
jrushlow added a commit to jrushlow/maker-bundle that referenced this pull request Sep 28, 2024
symfony/recipes#1339 is now merged - we dont need to skip these tests anymore.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Minor Minor Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant