deprecated the activation strategy class in favor of the one in Symfony #94
Conversation
|
I've kept the old class to avoid BC breaks, but we can also remove it altogether, depending on what we prefer and the version of the bundle it will be merged in. |
|
As I've migrated the class in Symfony to use the request stack, this PR won't work anymore. Let's see what happens to the PR for Symfony before deciding on the best strategy for the migration here. |
|
We should keep the support of older symfony versions IMO. Otherwise we will be forced to maintain several branches of the bundle in parallel because of the 2.3 LTS. |
|
+1 on 2.3 compat if possible, we can use the Symfony class if it's available and the bundle one otherwise, that way if some code is out of sync by accident the latest symfony code gets used at least. |
|
Not sure how to make things compatible and not break BC. Detecting which class to use can only be done on runtime as the user might have overridden the activation strategy class parameter. But then, the way to create the strategy is not the same (request vs request_stack.) The only way I can see is to create a factory that will create the strategy the right way, but honestly, that seems overkill to me. |
|
Yeah that's true. I guess we have to tag a 2.6+ release when that's out then.. |
|
Hi, |
|
I guess at some point we need to branch out for symfony 3.0 (or 2.7+) into a v3.0 of this bundle. |
This PR was squashed before being merged into the 3.x-dev branch (closes #169). Discussion ---------- Deprecate the NotFoundActivationStrategy class Use the version that is in monolog-bridge instead. That version uses request_stack rather than request from the service container, which means excluded_404s shall be properly ignored in Symfony 3. Replaces #94, Fixes #166 and invalidates #123. This change remains backwards compatible with Symfony 2.6 and above. Commits ------- b77bdf0 Deprecate the NotFoundActivationStrategy class
In symfony/symfony#11805, I propose to move the activation strategy class to the Symfont bridge. This PR deprecates the current class from the bundle in favor of the one in the bridge. Obviously, this PR can not be merged before the release of Symfony 2.6 at the earliest.