[WebProfilerBundle] Improve accessibility of tabs and some links #48762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Dec 22, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/cache.html.twig
Outdated
Show resolved
Hide resolved
javiereguiluz
force-pushed
the
accessibility
branch
from
be0e362 to
21a0396
Compare
|
Thanks for the review @stof. I did all the changes that your requested, including certain HTML structure changes to make it fully accessible. |
fabpot
requested changes
Jan 5, 2023
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jan 11, 2023
|
Thank you @javiereguiluz. |
stof
reviewed
Jan 11, 2023
|
|
||
| <li class="{{ has_error_logs ? 'active' }}"> | ||
| <button role="tab" class="tab-control {{ has_error_logs ? 'active' }}"> |
There was a problem hiding this comment.
This template puts an input inside a button, which is invalid HTML markup (and inaccessible one). You cannot have it being both a radio group and an ARIA tablist AFAICT.
There was a problem hiding this comment.
I'm going to fix it in a separate PR. Thanks.
Update: here's the PR: #48963
fabpot
added a commit
that referenced
this pull request
Jan 14, 2023
…anel filters (javiereguiluz) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #48762 (comment) | License | MIT | Doc PR | - This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed. Commits ------- a8523cb [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Jan 14, 2023
…anel filters (javiereguiluz) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#48762 (comment) | License | MIT | Doc PR | - This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed. Commits ------- a8523cb091 [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves Profiler accessibility a bit by: