[DoctrineBridge] Fix compatibility to Doctrine persistence 2.5 in Doctrine Bridge 6.4 to avoid Projects stuck on 6.3 #59185
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
Simply allowing 2.5 is unlikely to report actual breakages: the CI will install the highest compatible version, and so will keep installing version 3 |
|
@stof there is
Without the latest commit you see it did fail as 2.5 was installed: https://github.com/symfony/symfony/actions/runs/12280919774/job/34268515843?pr=59185 With a few line of changes I think may can catch that issue but need to invest. |
alexander-schranz
changed the title
|
With some version check in the tests it seems a way we could still support the persistence 2.5 version:
Other CI errors seems be unrelated. |
carsonbot
changed the title
|
ping @nicolas-grekas as you bumped the requirement in 0d4e2b8 |
|
Let me know if there is anything else here I should check. |
alexander-schranz
force-pushed
the
enhancement/doctrine-persistence-2
branch
from
0a6a5ab to
f3e5dea
Compare
alexander-schranz
force-pushed
the
enhancement/doctrine-persistence-2
branch
from
f3e5dea to
c29bcfe
Compare
…trine Bridge 6.4 to avoid Projects stuck on 6.3
fabpot
force-pushed
the
enhancement/doctrine-persistence-2
branch
from
c29bcfe to
df3cef8
Compare
|
Thank you @alexander-schranz. |
|
Are we going to revert this change after merging up? |
|
Think it is fine to revert this in |
…2.x (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [DoctrineBridge] clean up code for doctrine/persistence 2.x | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I missed this when merging `6.4` up after #59185 Commits ------- e102b89 clean up code for doctrine/persistence 2.x
Doctrine Bridge dropped support of persistence 2 from 6.3 to 6.4 but I could not yet find out why. (0d4e2b8). It making lot of things harder and get projects stuck on 6.3 which can not yet update doctrine/persistence because of some bc breaks (mostly
Bundle:Entitysyntax). It makes also eco system a little bit harder (doctrine/DoctrineBundle#1841, doctrine/DoctrineFixturesBundle#486, https://github.com/sulu/sulu/actions/runs/12050408254/job/34248387939) as with some changes in symfony and doctrine bundles things get downgraded to symfony 5.4 instead keep in 6.3. If there is any easy way to support persistence 2.5 still on 6.4 bridge I think things would get easier.Want with this PR check what fails on the CI if still allow persistence 2.5.
Update: Looks like with a few checkst we could get lowest run on persistence 2.5 which would so make easier projects upgrade to Symfony 6.4 without they have to tackle the persistence update in the same case.