Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…it is now deprecated by twig/twig 3.12 (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Remove `$tag` parameter from `*Node`, as it is now deprecated by twig/twig 3.12 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT This PR fix the deprecations added in twig/twig 3.12, about the `$tag` parameter from `Node` class: ``` ➜ TwigComponent git:(2.x) sf php vendor/bin/simple-phpunit PHPUnit 9.6.20 by Sebastian Bergmann and contributors. Testing ............................................................... 63 / 249 ( 25%) ............................................................... 126 / 249 ( 50%) ............................................................... 189 / 249 ( 75%) ............................................................ 249 / 249 (100%) Time: 00:00.514, Memory: 38.00 MB OK (249 tests, 632 assertions) Remaining direct deprecation notices (39) 28x: Since twig/twig 3.12: The "tag" constructor argument of the "Symfony\UX\TwigComponent\Twig\ComponentNode" class is deprecated and ignored (check which TokenParser class set it to "component"), the tag is now automatically set by the Parser when needed. 5x in EmbeddedComponentTest::testPassingDownBlocksMultipleLevelsNeedsToBeDoneManually from Symfony\UX\TwigComponent\Tests\Integration 3x in EmbeddedComponentTest::testDeepNesting from Symfony\UX\TwigComponent\Tests\Integration 3x in EmbeddedComponentTest::testItCanHandleMissingOuterBlocks from Symfony\UX\TwigComponent\Tests\Integration 3x in EmbeddedComponentTest::testBlockDefinitionCanAccessTheContextOfTheDestinationBlocks from Symfony\UX\TwigComponent\Tests\Integration 2x in EmbeddedComponentTest::testABlockIsNotPassedIntoAnEmbeddedComponent from Symfony\UX\TwigComponent\Tests\Integration ... 11x: Since twig/twig 3.12: The "tag" constructor argument of the "Symfony\UX\TwigComponent\Twig\PropsNode" class is deprecated and ignored (check which TokenParser class set it to "props"), the tag is now automatically set by the Parser when needed. 10x in ComponentPropsParserTest::testPropsData from Symfony\UX\TwigComponent\Tests\Integration\Twig 1x in TwigComponentDebugCommandTest::testWithAnonymousComponent from Symfony\UX\TwigComponent\Tests\Integration\Command Legacy deprecation notices (4) ➜ TwigComponent git:(2.x) ``` Commits ------- 4057b11 [TwigComponent] Remove `$tag` parameter from `*Node`, as it is now deprecated by twig/twig 3.12
- Loading branch information