[Twig][Live] Skip Twig 3.9 🚒 (do not set use_yield = true for now)
#1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I "revert" #1478 in this PR Please do not set "use_yield = true" while our compatibility is not OK. This is something that has a major impact on TwigComponent and LiveComponent, and we'll probably need some changes on the CI to handle both modes. |
smnandre
changed the title
use_yield = true for now)
weaverryan
reviewed
Feb 10, 2024
| @@ -29,7 +29,7 @@ | |||
| "php": ">=8.1", | |||
| "symfony/property-access": "^5.4.5|^6.0|^7.0", | |||
| "symfony/ux-twig-component": "^2.8", | |||
| "twig/twig": "^2.14.7|^3.0.4" | |||
| "twig/twig": "^2.14.7|~3.8.0" | |||
There was a problem hiding this comment.
Minor - but technically we are still ok if you’re using 3.0.4. We just want to not allow 3.9. Perhaps we should write it to still allow the lower twig 3 versions?
There was a problem hiding this comment.
How would you write this ? If we use <= it will allow twig 1.0 no ?
There was a problem hiding this comment.
hmm, I see you've just matched what Symfony core is doing. Ok for me then!
weaverryan
force-pushed
the
fix/skip-twig-3-9
branch
from
95e9431 to
6165384
Compare
|
Thanks Simon! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Symfony Twig Bridge & Twig Bundle have decided to skip Twig 3.9 for now, we should do the same, as testing and/or maintaining a compatible version would be really hard without the bundle support.
symfony/twig-bridge@2abddb1
symfony/twig-bundle@23a02ff
Update:
Twig 3.9 introduce a major change in the way templates are rendered, and to fully test/fix our compatibility, we need to wait Bridge and Bundle to allow Twig 3.9
In the meantime, please do not set "use_yield = true" as we are not ready yet.
This is something that has a major impact on TwigComponent and LiveComponent, and we'll probably need some changes on the CI / test suite to handle both modes.
Pull Request (compatibility - wip) : #1487 (help welcomed)
Issue: #1390
Twig PR : twigphp/Twig#3950