Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[root] Upgrade JS build dependencies #2075

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 17, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Some maintenance on our root JS dependencies, upgrading Rollup, TypeScript, Babel, ...

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 17, 2024
@@ -96,7 +96,7 @@ module.exports = {
filterRoot: packageRoot,
include: ['src/**/*.ts'],
compilerOptions: {
outDir: 'dist',
outDir: '.',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of rollup/plugins#1378

Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this topic, you're way more qualified than me here 😅

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 17, 2024
@kbond kbond force-pushed the chore/update-js-build-deps branch from d357ab6 to 5f54579 Compare August 20, 2024 15:47
@kbond
Copy link
Member

kbond commented Aug 20, 2024

Thanks Hugo.

@kbond kbond merged commit 5b8d3f4 into symfony:2.x Aug 20, 2024
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants