Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TwigComponent][Doc] Twig code style & "boolean props" part #2082

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Aug 18, 2024

Fix code style in Twig examples (to follow twig & symfony code conventions)

Also rewrite/improved the paragraph about "boolean props"

  • explain how it works and why
  • increase visibility of the solutions

(it's been some time I wanted to rewrite this part, as we often have questions)

@smnandre smnandre changed the title [TwigComponent] Fix Twig code style + Improve "boolean props" part [TwigComponent][Doc] Twig code style & "boolean props" part Aug 18, 2024
@smnandre smnandre added the docs Improvements or additions to documentation label Aug 18, 2024
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emoji's are a nice touch!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 20, 2024
src/TwigComponent/doc/index.rst Outdated Show resolved Hide resolved
src/TwigComponent/doc/index.rst Outdated Show resolved Hide resolved
src/TwigComponent/doc/index.rst Outdated Show resolved Hide resolved
@smnandre
Copy link
Member Author

Thanks @WebMamba for the corrections :)

@smnandre smnandre merged commit 93027de into symfony:2.x Aug 21, 2024
2 checks passed
@smnandre smnandre deleted the doc/clean-twig-syntax branch August 21, 2024 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants