Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TwigComponent] Add notice about needing phpdocumentor/reflection-docblock #2102

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

dejagersh
Copy link
Contributor

@dejagersh dejagersh commented Aug 28, 2024

Q A
Bug fix? no
New feature? no
Issues NA
License MIT

This notice is present in this in section Using DTO's on a LiveProp but not here: LiveProp for Entities & More Complex Data

image

This is where I personally ran into trouble. https://symfony-devs.slack.com/archives/C01FN4EQNLX/p1724839078396519

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 28, 2024
@smnandre smnandre added docs Improvements or additions to documentation TwigComponent labels Aug 31, 2024
@smnandre smnandre changed the title Add notice about needing phpdocumentor/reflection-docblock [TwigComponent] Add notice about needing phpdocumentor/reflection-docblock Aug 31, 2024
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor CS fix and let's merge this :)

src/LiveComponent/doc/index.rst Outdated Show resolved Hide resolved
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dejagersh 😃

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 3, 2024
@smnandre smnandre merged commit 79b584f into symfony:2.x Sep 3, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants