[Autocomplete] Translate "Add ..." text #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Autocomplete
Feature
|
UX Website & Live/Twig components workflow failures are unrelated (due to Twig release from yesterday I guess). Not sure why the Autocomplete workflow fails, the tests are working locally :/ |
Kocal
reviewed
Aug 30, 2024
|
@jmsche Did you check if passing option_create every time to the instance would not be interpreted by TomSelect as "create: true" ? I believe it worked like that at a time I would not want we add an unwanted option to every existing user :) |
|
@smnandre Just checked locally, adding autocomplete on an EnumType, create option is not offered so everything seems okay :) |
smnandre
approved these changes
Sep 1, 2024
carsonbot
added
Status: Reviewed
|
@smnandre Changelog entry added :) |
carsonbot
added
Status: Needs Review
|
The Autocomplete test (PHP 8.3) are failing :| |
smnandre
requested changes
Sep 2, 2024
carsonbot
added
Status: Needs Work
|
@smnandre TBH I don't know why the This test is passing on my local machine, and I guess if you run it again on CI it should pass 😅 |
smnandre
reviewed
Sep 3, 2024
carsonbot
added
Status: Needs Review
smnandre
approved these changes
Sep 3, 2024
carsonbot
added
Status: Reviewed
1ed
reviewed
Sep 3, 2024
Kocal
approved these changes
Sep 6, 2024
smnandre
force-pushed
the
autocomplete-add-text
branch
from
4589d81
to
f4c647f
Compare
|
Thanks @jmsche. |
kbond
added a commit
that referenced
this pull request
Oct 21, 2024
…setup (Jonas De Keukelaere) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Autocomplete] Translate "Add ..." text with remote data setup | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT In #2108 the "Add..." translation has been added. But this only worked for non remote data setups. This PR makes it work for remote data setup too. Also add translation for Dutch. Commits ------- d2b26d3 [Autocomplete] Translate "Add ..." text with remote data setup
symfony-splitter
pushed a commit
to symfony/ux-autocomplete
that referenced
this pull request
Oct 21, 2024
…setup (Jonas De Keukelaere) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Autocomplete] Translate "Add ..." text with remote data setup | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT In symfony/ux#2108 the "Add..." translation has been added. But this only worked for non remote data setups. This PR makes it work for remote data setup too. Also add translation for Dutch. Commits ------- d2b26d36 [Autocomplete] Translate "Add ..." text with remote data setup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes #745, allowing to translate the "Add Abc..." text when the create option is set to true :)
Added the translated text as comment in most translation files.