Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[TwigComponent] Use a RuntimeExtension #2168

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[TwigComponent] Use a RuntimeExtension #2168

merged 1 commit into from
Sep 16, 2024

Conversation

smnandre
Copy link
Member

  • Hide implementation & start decoupling the template from the event system
  • Optimize (a bit) the ComponentNode

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Sep 15, 2024
@smnandre smnandre requested a review from kbond September 15, 2024 03:23
@smnandre smnandre changed the title [Twig] Use a RuntimeExtension [TwigComponent] Use a RuntimeExtension Sep 15, 2024
@smnandre smnandre requested a review from kbond September 15, 2024 10:53
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 15, 2024
javiereguiluz
javiereguiluz approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@javiereguiluz javiereguiluz merged commit 292f41d into symfony:2.x Sep 16, 2024
1 check was pending
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kocal Kocal Kocal approved these changes

@kbond kbond kbond approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smnandre @javiereguiluz @kbond @Kocal @carsonbot