Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Site] Fix tooltips positioning on FileTree component #2190

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Kocal
Copy link
Collaborator

@Kocal Kocal commented Sep 20, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Before:

Enregistrement.de.l.ecran.2024-09-20.a.09.49.54.mov

After:

Enregistrement.de.l.ecran.2024-09-20.a.09.52.26.mov

@carsonbot carsonbot added Site Status: Needs Review Needs to be reviewed labels Sep 20, 2024
@@ -1,6 +1,6 @@
{% macro summaryAttributes(description) %}
{% if description %}
data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="auto" title="{{ description|e('html_attr') }}"
data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="right" title="{{ description|e('html_attr') }}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for the fix, but it was more friendly

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks better.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 20, 2024
@Kocal Kocal merged commit 4705d03 into symfony:2.x Sep 20, 2024
3 of 4 checks passed
@Kocal Kocal deleted the site-fix-homepage-tooltips branch September 20, 2024 08:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Site Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants