Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed typo in links to Symfony UX repo #2193

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fixed typo in links to Symfony UX repo #2193

merged 1 commit into from
Sep 23, 2024

Conversation

sblum51
Copy link
Contributor

@sblum51 sblum51 commented Sep 23, 2024

I fixed typo in the links to Symfony UX repo (before: symfony/symfony-ux).
Note: I wasn't able to deal with the "version" variable.

Q A
Bug fix? no
New feature? no
Issues
License MIT

Before : https://github.com/symfony/symfony-ux/blob/4.4/src/Map/src/Bridge/Leaflet/README.md (404)
Now : https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Leaflet/README.md

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Sep 23, 2024
@Kocal
Copy link
Member

Kocal commented Sep 23, 2024

Thanks!

But note that only the symfony-ux part was wrong, blob/{version} is fine but it looks like version is not interpreted correctly by the Symfony docs.

I'm merging, and ask to the appropriate persons for {version} :)

I fixed typo in the links to Symfony UX repo (before: symfony/symfony-ux).
Note: I wasn't able to deal with the "version" variable.
@Kocal
Copy link
Member

Kocal commented Sep 23, 2024

Thank you @sblum51.

@Kocal Kocal merged commit c3f5389 into symfony:2.x Sep 23, 2024
2 checks passed
Kocal added a commit that referenced this pull request Sep 23, 2024
This PR was merged into the 2.x branch.

Discussion
----------

[Doc] Fix some links in UX Map docs

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Issues        | -
| License       | MIT

Related to #2193. The `{version}` placeholder only works for Symfony Docs and I'm not sure it can be extended to also work on UX. So, let's just hardcode the `2.x` version number because this is fine.

Commits
-------

b234d43 [Doc] Fix some links in UX Map docs
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants