[Map] Fix Google/Leaflet bridges when using Webpack Encore #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
fix-map-bridges-webpack
branch
from
450b96d
to
5abfff3
Compare
Kocal
force-pushed
the
fix-map-bridges-webpack
branch
from
5abfff3
to
b3283f4
Compare
Kocal
commented
Sep 23, 2024
| @@ -1,8 +1,48 @@ | |||
| import AbstractMapController from '@symfony/ux-map/abstract-map-controller'; | |||
| import { Controller } from '@hotwired/stimulus'; | |||
There was a problem hiding this comment.
Surely because Rollup has been able to resolve the file when using import AbstractMapController from '@symfony/ux-map', the AbstractMapController is now inlined.
I'm fine with this, especially it removes one useless HTTP request.
carsonbot
added
Status: Reviewed
kbond
approved these changes
Sep 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2105, and ensures Leaflet and GoogleMaps bridges are working fine with Webpack Encore.
To be sure:
--webapp),.addAliases({ 'leaflet/dist/leaflet.min.css': 'leaflet/dist/leaflet.css' })and.enableStimulusBridge('./assets/controllers.json')inwebpack.config.jsnew Map()) and rendered it (ux_map(map, { style: 'height: ...' }))I am able to display a Leaflet map:
And a GoogleMap maps:
The Map rendered on ux.symfony.com is also working (after updating the
importmap.phpas documented):