Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Map] Explicitly require StimulusBundle in Bridges, fix tests #2207

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Kocal
Copy link
Collaborator

@Kocal Kocal commented Sep 25, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Follows #2180.

When installing a Map Bridge dependencies, the StimulusBundle was not the one from the PR's branch but from 2.x, and so tests didn't fail in #2180 but started to fail after merging:

image

@carsonbot carsonbot added Map Status: Needs Review Needs to be reviewed labels Sep 25, 2024
@Kocal Kocal changed the title [Map] Explicitly require StimulusBundle in Bridges [Map] Explicitly require StimulusBundle in Bridges, fix tests Sep 25, 2024
@Kocal Kocal merged commit e51918f into symfony:2.x Sep 25, 2024
59 checks passed
@Kocal Kocal deleted the fix/map-bridges-tests branch September 25, 2024 14:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Map Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants