Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade css-minimizer-webpack-plugin to fix vulnerability YAML #1203

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

sloury
Copy link
Contributor

@sloury sloury commented Apr 25, 2023

Bump Vulnerability from dependencies YAML, after 'yarn audit'

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate │ Uncaught Exception in yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.2.2 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @symfony/webpack-encore │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @symfony/webpack-encore > css-minimizer-webpack-plugin > │
│ │ cssnano > yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1091814
└───────────────┴──────────────────────────────────────────────────────────────┘

Upgrade the package version of css-minimizer-webpack-plugin:^5.0.0 seem to fix this warning

@Kocal
Copy link
Member

Kocal commented Jul 10, 2023

This would be a must have, actually this plugin depends of a version of CSSNano that depends of deprecated stable@0.1.8.

@weaverryan
Copy link
Member

Thanks @sloury! And sorry for the delay. Note to anyone else checking this: while we do need to upgrade this to allow for a clean security advisory check, the underlying code with the security flaw does not appear to be anything that is used by Encore - it was related to YAML incorrectly throwing an exception when fed too much data - not relevant.

@weaverryan weaverryan merged commit cf3c24d into symfony:main Jul 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants