Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace assets-webpack-plugin dependency by an internal plugin, to generate entrypoints.json file #1342

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Sep 17, 2024

Q A
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #969
License MIT

This PR replaces the https://github.com/ztoben/assets-webpack-plugin dependency with an internal plugin, this allows us:

Things done in this PR:

Things not done in this PR:

@Kocal Kocal marked this pull request as ready for review September 17, 2024 19:53
Comment on lines +70 to +77
// We don't want to include hot-update files in the manifest
if (asset.name.includes('.hot-update.')) {
continue;
}
Copy link
Contributor Author

@Kocal Kocal Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you update a file while the dev-server is running, an .hot-update. file can be emitted, but we don't want to add it in the manifest.

@Kocal Kocal added this to the 5.0 milestone Sep 17, 2024
@Kocal Kocal requested a review from stof September 17, 2024 20:04
@Kocal Kocal added the Feature New Feature label Sep 17, 2024
@Kocal Kocal merged commit b212b15 into symfony:main Sep 20, 2024
28 checks passed
@Kocal Kocal deleted the drop-assets-webpack-plugin branch September 20, 2024 07:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoints integrity workaround needed to allow for assets-webpack-plugin or higher
2 participants