Skip to content

Commit

Permalink
minor #28025 Use an empty string as default for assertEquals (DavidPr…
Browse files Browse the repository at this point in the history
…evot)

This PR was merged into the 3.4 branch.

Discussion
----------

Use an empty string as default for assertEquals

Make sure it isn’t interpreted as a type NULL, making the test fail with PHPUnit 7.2.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This shouldn’t break the existing tests, but will also make them work with recent PHPUnit.

Commits
-------

31353147a3 Use an empty string as default for assertEquals
  • Loading branch information
nicolas-grekas committed Jul 26, 2018
2 parents 87bd4af + 4598d79 commit dfc2bcb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Tests/Fixtures/escapedCharacters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ yaml: |
php: |
"\\0 \\ \\a \\b \\n"
---
test: null
test: 'null'
yaml: |
"\0"
php: |
Expand Down

0 comments on commit dfc2bcb

Please # to comment.