New discovery protocol over HTTPS #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| panic("stop unimplemented") | ||
| } | ||
| func (s *querysrv) handleGET(w http.ResponseWriter, req *http.Request) { | ||
| if req.TLS == nil { |
There was a problem hiding this comment.
We don't really need this for gets
There was a problem hiding this comment.
Well, we don't even listen on non-TLS so not really, no.
There was a problem hiding this comment.
This talks about wether or not the client provided a cert. I'd like to be able to easily ask people to use curl to debug stuff, without asking them to generate a key pair. I understand that for POST its not an option.
There was a problem hiding this comment.
Nah, this just verifies that the GET was over TLS at all, no check of the client cert. curl -k works perfectly fine against the discosrv for GET requests.
|
Does this work? |
|
Yeah :) |
AudriusButkevicius
added a commit
that referenced
this pull request
Sep 21, 2015
New discovery protocol over HTTPS
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe have a look-see here as well