-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix add_torrent, adding missing param #29
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request fixes the addTorrent function by ensuring that the uris parameter is properly initialized when not provided. The change involves checking for a null or missing uris value and replacing it with an empty list before appending it to the parameter list. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anasty17 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider checking for None (e.g., if uris is None) instead of falsy values to avoid unintentionally overriding valid empty list inputs.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fix #28
Summary by Sourcery
Bug Fixes:
addTorrent
method to resolve issue Aria2rpcException: unexpected result: {'id': 6, 'jsonrpc': '2.0', 'error': {'code': 1, 'message': 'The parameter at 1 has wrong type.'}} #28.