Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DX] Remove symfony/web-server-bundle #17

Merged
merged 2 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,8 @@ $ make reset

### Opening Sylius with your plugin

- Using `test` environment:

```bash
$ (cd tests/Application && bin/console server:run -d public -e test)
```

- Using `dev` environment:

```bash
$ (cd tests/Application && bin/console server:run -d public -e dev)
```
```bash
$ (cd tests/Application && symfony server:start --dir=public)
```
25 changes: 12 additions & 13 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,27 @@
"thenetworg/oauth2-azure": "^2.2"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "3.39.0",
"friendsoftwig/twigcs": "6.2.0",
"friendsofphp/php-cs-fixer": "3.46.0",
"friendsoftwig/twigcs": "6.4.0",
"j13k/yaml-lint": "1.1.5",
"php-parallel-lint/php-parallel-lint": "1.3.2",
"phpmd/phpmd": "2.14.1",
"phpro/grumphp": "2.3.0",
"phpmd/phpmd": "2.15.0",
"phpro/grumphp": "2.4.0",
"phpstan/extension-installer": "1.3.1",
"phpstan/phpstan": "1.10.44",
"phpstan/phpstan": "1.10.52",
"phpstan/phpstan-doctrine": "1.3.53",
"phpstan/phpstan-phpunit": "1.3.15",
"phpstan/phpstan-strict-rules": "1.5.2",
"phpstan/phpstan-webmozart-assert": "1.2.4",
"phpunit/phpunit": "10.4.2",
"phpunit/phpunit": "10.5.5",
"povils/phpmnd": "3.3.0",
"rector/rector": "0.18.10",
"seld/jsonlint": "1.10.0",
"squizlabs/php_codesniffer": "3.7.2",
"rector/rector": "0.18.13",
"seld/jsonlint": "1.10.1",
"squizlabs/php_codesniffer": "3.8.0",
"sylius-labs/coding-standard": "4.3.1",
"symfony/browser-kit": "6.3.8",
"symfony/debug-bundle": "6.3.2",
"symfony/dotenv": "6.3.7",
"symfony/web-server-bundle": "4.4.44",
"symfony/browser-kit": "6.4.0",
"symfony/debug-bundle": "6.4.0",
"symfony/dotenv": "6.4.2",
"webmozart/assert": "1.11.0"
},
"config": {
Expand Down
3 changes: 2 additions & 1 deletion src/Security/Authenticator/OauthAuthenticator.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public function __construct(
private Providers $providers,
private ?string $googleClientId,
private ?string $microsoftClientId
) {}
) {
}

/**
* {@inheritdoc}
Expand Down
4 changes: 3 additions & 1 deletion src/Security/Exception/DomainNotAuthorizedException.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@

namespace Synolia\SyliusAdminOauthPlugin\Security\Exception;

final class DomainNotAuthorizedException extends \Exception {}
final class DomainNotAuthorizedException extends \Exception
{
}
4 changes: 3 additions & 1 deletion src/Security/Exception/NoOauthClientProvidedException.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@

namespace Synolia\SyliusAdminOauthPlugin\Security\Exception;

final class NoOauthClientProvidedException extends \Exception {}
final class NoOauthClientProvidedException extends \Exception
{
}
4 changes: 3 additions & 1 deletion src/Security/Exception/NoProviderFoundException.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@

namespace Synolia\SyliusAdminOauthPlugin\Security\Exception;

final class NoProviderFoundException extends \Exception {}
final class NoProviderFoundException extends \Exception
{
}
3 changes: 2 additions & 1 deletion src/Security/Resolver/DomainInformationsResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ final class DomainInformationsResolver
{
public function __construct(
private LocaleContextInterface $localeContext
) {}
) {
}

/**
* @return array<string, array<string, AdminUser|string|null>>
Expand Down
3 changes: 2 additions & 1 deletion src/Service/UserCreationService.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ public function __construct(
private EntityManagerInterface $entityManager,
private RepositoryInterface $adminUserRepository,
private DomainInformationsResolver $domainInformationsResolver
) {}
) {
}

public function create(AzureResourceOwner|GoogleUser $user): ?AdminUser
{
Expand Down